Skip to content

Conversation

@NathanHB
Copy link
Member

No description provided.

@NathanHB NathanHB changed the base branch from main to nathan-add-closed-source November 26, 2024 13:15
@clefourrier
Copy link
Member

Tell me when you want me to revieeew :D

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks much nicer, but we now have code which is heavily duplicated between the create_model_config and specific config classes and parsing logic here

@NathanHB NathanHB changed the base branch from nathan-add-closed-source to main December 3, 2024 12:05
@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@NathanHB NathanHB requested a review from clefourrier December 3, 2024 15:36
@NathanHB NathanHB merged commit 6e2754e into main Dec 4, 2024
3 checks passed
hynky1999 pushed a commit that referenced this pull request May 22, 2025
Complete revamp of the cli. See documentation for more details. `lighteval --help`
NathanHB added a commit that referenced this pull request Sep 19, 2025
Complete revamp of the cli. See documentation for more details. `lighteval --help`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants